Upgrade Python version in Windows CI#571
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 88 88
Lines 8028 8028
=======================================
Hits 7806 7806
Misses 222 222 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AdamGleave
approved these changes
Sep 29, 2022
AdamGleave
left a comment
AdamGleave
left a comment
Member
There was a problem hiding this comment.
LGTM. Weird choco doesn't just default to installing the most recent version 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Windows is currently failing CI in some PRs (e.g. https://app.circleci.com/pipelines/github/HumanCompatibleAI/imitation/2721/workflows/015d1fb1-21f8-4245-aeae-85a8f0524c24/jobs/8509/steps, #537) due to a bug in an old version of CPython (python/cpython#83396). This was fixed in python/cpython#17827, but since chocolatey is installing python 3.8.0., this (and other CPython bugs) are still present.
This PR upgrades python on windows to the most recent version available on chocolatey (3.8.10). At the time of writing, the most recent python version is actually 3.8.14.